remove unreachable null result check in GetBlobs#6080
Closed
SimonCropp wants to merge 1 commit intoopen-telemetry:mainfrom
SimonCropp:remove-unreachable-null-result-check-in-GetBlobs
Closed
remove unreachable null result check in GetBlobs#6080SimonCropp wants to merge 1 commit intoopen-telemetry:mainfrom SimonCropp:remove-unreachable-null-result-check-in-GetBlobs
SimonCropp wants to merge 1 commit intoopen-telemetry:mainfrom
SimonCropp:remove-unreachable-null-result-check-in-GetBlobs
Conversation
github-actions
bot
added
the
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol
Kielek
requested changes
Jan 20, 2025
Member
Kielek
left a comment
Kielek
left a comment
There was a problem hiding this comment.
Please update first https://github.com/open-telemetry/opentelemetry-dotnet-contrib/tree/89f0af731441a364779693a1874c57f33b1e721c/src/OpenTelemetry.PersistentStorage.Abstractions
Then we can resync packages
Contributor
Author
|
@Kielek i dont understand |
Member
|
You are trying to update PersistentBlobProvider. This class is borrowed from the conitrb repository. If you want to modify it, please do it in the contrib repo. Then we can propagate changes here. |
SimonCropp
deleted the
remove-unreachable-null-result-check-in-GetBlobs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes